Patches

• Patches sent in should be in diff -u (“unified diff”) format. The correct order for the command is “diff oldfile newfile”, not “diff newfile oldfile”. If you are adding new files use the -N option. You should not send in a patch in “normal” diff ^[13] format.

  • Alternatively you can use svn diff (which automatically outputs a native unified diff format).

  • You can also use the cvsreport.pl tool with the -d option (which automatically handles file comparison between your live tree and the multiple repositories under your cvs directory).

• Follow the other programming guidelines, such as trimming trailing whitespace, and using (four) spaces not tabs for indentation.

• Your patch should be made against the current SVN trunk revision. [view] [svn] Please see the Six Apart Code website for repository links to other component parts.

• Please test your patch before you submit it; possible exceptions to this are small or simple modifications, like text changes. Apply your code and check its functionality from different angles, like community accounts, while logged-in and logged-out, etc. Try to make sure that as well as doing what you intend it to, it does not cause unexpected results in other areas.

• You can submit patches by posting an entry to the lj_dev community, on LiveJournal.com. You can place a keyword like [patch] in the subject line, if you wish.

• Don't send in patches that comment out old code. If we want the old code, we'll go get it from SVN… that's what it's for.